Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SELC-5420] feat: added field istatCode into onboarding #461

Merged
merged 11 commits into from
Sep 6, 2024
Merged

[SELC-5420] feat: added field istatCode into onboarding #461

merged 11 commits into from
Sep 6, 2024

Conversation

pierpaolodidato89
Copy link
Collaborator

List of Changes

  • added field istatCode into onboarding, retrieving value from proxy registry
  • Refactor logic of additional checks on onboarding data

Motivation and Context

How Has This Been Tested?

I have deployed the feature branch in DEV and tested the different scenario:

  • AOO onboarding
  • UO onboarding
  • EC onboarding

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@pierpaolodidato89 pierpaolodidato89 marked this pull request as ready for review September 3, 2024 15:46
@pierpaolodidato89 pierpaolodidato89 requested a review from a team as a code owner September 3, 2024 15:46
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 6, 2024

Quality Gate Passed Quality Gate passed

Issues
15 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pierpaolodidato89 pierpaolodidato89 merged commit 0898d73 into main Sep 6, 2024
9 checks passed
@pierpaolodidato89 pierpaolodidato89 deleted the feature/SELC-5420 branch September 6, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrea-putzu andrea-putzu andrea-putzu approved these changes

Assignees
No one assigned
Labels
onboarding-ms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierpaolodidato89 @andrea-putzu